zMenu icon indicating copy to clipboard operation
zMenu copied to clipboard

More languages support

Open lijinhong11 opened this issue 2 years ago • 7 comments

The enum message cannot be customized at all (excluding decompile jars) And I saw some people in China who like your plugin (some people from other countries should also be), so I really hope you can rewrite a message processing structure. The structure is as follows:

  1. Create MessageHandler
  2. Put some methods about send and get
  3. Other classes use MessageHandler to get or send messages

And there's some questions I want to ask:

  1. Why you use the useless enum Message object?
  2. Why MessageLoader needs set message in a Message object? I think create another class to store message context (not the Message object) is great.

lijinhong11 avatar Nov 18 '23 03:11 lijinhong11

It is true that the entire system must be changed. And the enum will allow to save messages in a very simple way. But for a multi-language message system this will not be suitable

Maxlego08 avatar Nov 18 '23 10:11 Maxlego08

Yea it needs change them all. And I can help you rewrite the message handler.


发件人: Maxence Simon @.> 发送时间: 2023年11月18日 18:30 收件人: Maxlego08/zMenu @.> 抄送: lijinhong11 @.>; Author @.> 主题: Re: [Maxlego08/zMenu] More languages support (Issue #17)

It is true that the entire system must be changed. And the enum will allow to save messages in a very simple way. But for a multi-language message system this will not be suitable

― Reply to this email directly, view it on GitHubhttps://github.com/Maxlego08/zMenu/issues/17#issuecomment-1817470711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO6JU5EZRFBEDBEZ7UX2H6TYFCE27AVCNFSM6AAAAAA7QVSGTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGQ3TANZRGE. You are receiving this because you authored the thread.Message ID: @.***>

lijinhong11 avatar Nov 18 '23 11:11 lijinhong11

if you have a system idea why not

Maxlego08 avatar Nov 18 '23 11:11 Maxlego08

because I can't remove the old message system at all


发件人: Maxence Simon @.> 发送时间: 2023年11月18日 19:47 收件人: Maxlego08/zMenu @.> 抄送: lijinhong11 @.>; Author @.> 主题: Re: [Maxlego08/zMenu] More languages support (Issue #17)

if you have a system idea why not

― Reply to this email directly, view it on GitHubhttps://github.com/Maxlego08/zMenu/issues/17#issuecomment-1817486803, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO6JU5ABE5YPW3HV6RGRJXTYFCN3XAVCNFSM6AAAAAA7QVSGTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGQ4DMOBQGM. You are receiving this because you authored the thread.Message ID: @.***>

lijinhong11 avatar Nov 18 '23 11:11 lijinhong11

You can start a new system and I would adapt it to work on the plugin

Maxlego08 avatar Nov 18 '23 12:11 Maxlego08

Ok.


发件人: Maxence Simon @.> 发送时间: 2023年11月18日 20:05 收件人: Maxlego08/zMenu @.> 抄送: lijinhong11 @.>; Author @.> 主题: Re: [Maxlego08/zMenu] More languages support (Issue #17)

You can start a new system and I would adapt it to work on the plugin

― Reply to this email directly, view it on GitHubhttps://github.com/Maxlego08/zMenu/issues/17#issuecomment-1817490706, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO6JU5E43AIJFQSSBTPWL5TYFCQCHAVCNFSM6AAAAAA7QVSGTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGQ4TANZQGY. You are receiving this because you authored the thread.Message ID: @.***>

lijinhong11 avatar Nov 18 '23 12:11 lijinhong11

#18 here. And I really want the plugin to listen to file context changing and then auto reload. (But I can't)

lijinhong11 avatar Nov 18 '23 13:11 lijinhong11