[Bug] HUGE economy BUG ⏰⏰⏰

[MrLouisDew]

Terms

• [x] I'm using the very latest version of zEssentials and its dependencies (zMenu and PlaceholdersAPI).
• [x] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
• [x] I've looked for already existing issues on the Issue Tracker and haven't found any.
• [x] I already searched on the plugin wiki to know if a solution is already known.
• [x] I already searched on the discord to check if anyone already has a solution for this.
• [x] I tested this with just zEssentials and its dependencies and with a vanilla client of the same version as the Server.
• [x] I enabled the debug mode in config.yml and sql debug

Discord Username (optional)

uekc

Server Version

1.21.1

Server Software

[20:50:58 INFO]: Current Purpur Version: 1.21.1-2329-803bf62 (MC: 1.21.1)*

zEssentials Version

[12:57:01 INFO]: zEssentials version 1.0.1.7

zMenu Version

[12:57:08 INFO]: zMenu version 1.0.3.7

What happened?

To let players make teams I use the BetterTeams plugin. This plugin also allows teams to have a team bank account where they can withdraw and deposit money. They can deposit unlimited amounts of money to their team bank even tho min (minimum possible number in config.yml in economy module) is set to 0. The amount does get deducted from their balance until it reaches 0. When a player has 0 balance they can still for example deposit 1 million currency into the team bank. I first thought this was a BetterTeams issue but this seems to not be the case after talking to the developer. The developer said the economy plugin (in this case zEssentials) has to mark the transaction as valid in order for the deposit to happen. This does also not happen with EssentialsX for example. Please fix this, this is an unlimited money generator.

Steps to reproduce the issue

1. Install BetterTeams
2. Deposit money even tho balance = 0
3. See that you can still deposit sums of money even tho bal = 0

Full Server Log

https://mclo.gs/fzPYdb8

Error (optional)

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

[Maxlego08]

Do you use a plugin like Vault to manage the economy? can you send me the link to the code of betterteams? Because the problem seems to me more related to an incorrect use of the API

[MrLouisDew]

Do you use a plugin like Vault to manage the economy? can you send me the link to the code of betterteams? Because the problem seems to me more related to an incorrect use of the API

Yes I use Vault. Link to BetterTeams code: https://github.com/booksaw/BetterTeams