Seq2Seq-PyTorch icon indicating copy to clipboard operation
Seq2Seq-PyTorch copied to clipboard

get_best() returns index 1

Open VSJMilewski opened this issue 7 years ago • 1 comments

Hi. In the beam_search.py you have a function get_best(). Shouldn't this return the first element, as in index 0, of the sorted list instead of index 1?

VSJMilewski avatar Oct 04 '18 09:10 VSJMilewski

Hi @victormilewski1994 the beam_search.py code that I have right now is non-functional, I would not recommend using it.

MaximumEntropy avatar Oct 22 '18 06:10 MaximumEntropy