Roblox-Studio-Mod-Manager icon indicating copy to clipboard operation
Roblox-Studio-Mod-Manager copied to clipboard

Studio updates force close all active Studio processes

Open HooferDevelops opened this issue 1 year ago • 3 comments

When launching the Mod Manager, in the event there is an update for Roblox Studio, it will forcefully close all active studio processes. It does this prior to asking if I would like to close studio.

This is really frustrating, as there are cases where I mistakenly have clicked on mod manager, for it to open and forcefully close all of my studio sessions before I have time to react.

The intended behavior should be that it would only kill the processes after I confirm my action.

HooferDevelops avatar Jul 18 '24 02:07 HooferDevelops

This issue happens here: https://github.com/MaximumADHD/Roblox-Studio-Mod-Manager/blob/3d289f047b66bf40db58d6e7f8a959ec6984190b/ProjectSrc/Bootstrapper/StudioBootstrapper.cs#L673-L752

You can see that it attempts to close all the processes prior to the prompt.

HooferDevelops avatar Jul 18 '24 02:07 HooferDevelops

Sure, I'll tweak this.

MaximumADHD avatar Jul 18 '24 02:07 MaximumADHD

Another bug I found is that the message box prompts below the Mod Manager, I've found this can be fixed by adding MessageBoxDefaultButton.Button1, MessageBoxOptions.DefaultDesktopOnly to the MessageBox.Show prompt.

I fixed these issues myself on a separate branch, I can PR if wanted.

https://github.com/user-attachments/assets/2bf6c064-3825-430e-838a-ca07670d649a

HooferDevelops avatar Jul 18 '24 03:07 HooferDevelops

Change is merged and applied in the latest update!

MaximumADHD avatar Apr 25 '25 23:04 MaximumADHD