google-api-typings-generator

google-api-typings-generator copied to clipboard

Historically we've been using the same linting process as DefinitelyTyped, because generated types were meant to be published there, so it made sense to use the same testing. However now...

Maxim-Mazurok

gapi => gapi.client

2

We actually use @types/gapi.client, not @types/gapi

Maxim-Mazurok

resource methods: deduplicate request types between regular and body methods

2

declanvong

For example, in https://walletobjects.googleapis.com/$discovery/rest?version=v1 there is `JwtResource` interface in `schemas`. However, there's also `jwt` resource in the `resources` object, for which we generate `JwtResource` name. I think I've already seen...

Maxim-Mazurok

There are interfaces such as `Function` in `types/gapi.client.cloudfunctions-v2/index.d.ts`, for example. This is kinda reserved word, similar to `Object` or `Symbol`, and we probably don't want to mess with that. However...

Maxim-Mazurok

As per https://github.com/igor-dv/jest-specific-snapshot/issues/27#issuecomment-1483803179 ~~Give https://github.com/satya164/jest-file-snapshot a try~~ Actually this looks even better: https://vitest.dev/guide/snapshot.html#file-snapshots

Maxim-Mazurok

Consider adding error response interfaces

1

>> ```json >> { >> "error": { >> "code": 403, >> "message": "The video identified by the videoId parameter has disabled comments.", >> "errors": [ >> { >> "message": "The...

Maxim-Mazurok

> In order for a parameter to be non-undefined it has to have `"required": true` property. For example, `VideoResource.rate` has `id: string` and `rating: string` because both of them have...

Maxim-Mazurok

For example, `valueRenderOption` from https://sheets.googleapis.com/$discovery/rest?version=v4 ``` "valueRenderOption": { "enum": [ "FORMATTED_VALUE", "UNFORMATTED_VALUE", "FORMULA" ], "description": "How values should be represented in the output. The default render option is ValueRenderOption.FORMATTED_VALUE.", "enumDescriptions":...

Maxim-Mazurok

cspell on windows attempts to check `test\restDocs`, need to avoid that. Probably use this script (may need to adapt it): ```ts import path, { dirname } from "path"; import {...

Maxim-Mazurok