ERC2981 icon indicating copy to clipboard operation
ERC2981 copied to clipboard

Change case on return value & format code for readability

Open cliffhall opened this issue 3 years ago • 1 comments

https://github.com/MaxflowO2/ERC2981/blob/010744cac3e6c5214a184733faa59cca61884daa/contracts/ERC2981.sol#L49

Readability is important in reference and framework code. Formatting it with that in mind (as we did in the ERC), will be appreciated by those who evaluate it when considering adoption.

function royaltyInfo(uint256 _tokenId, uint256 _salePrice) 
external 
view 
override(IERC2981) 
returns (address Receiver, uint256 royaltyAmount) { }

Also, return values should begin with lower case receiver not Receiver.

cliffhall avatar Sep 15 '21 15:09 cliffhall

Yeah long night when I wrote this, but out of my silly season for a bit will update accordingly

MaxflowO2 avatar Sep 25 '21 03:09 MaxflowO2