Max Kellermann
Max Kellermann
Most are - but look at the confusing commit which added `synchronized` to the FTP provider: cd9e19f8eb6de22a3a545064ab0e68254bd243a2 Without requiring providers to be thread-safe, this commit doesn't make sense. Few providers...
I added commits for fixing the obvious TOCTOU bugs in SFTP and HDFS. The other provides look like they don't need to be fixed.
Unit test failures because the `HdfsFileObject` class is a big fuckup ... it calls the internal method `doAttach()`, circumventing `attach()`, i.e. the base class `AbstractFileObject` can't keep the `attached` flag...
> BTW I always try to use a VFS manager single threaded, I am not completely sure but most of the code looks like this was the intended use anyway...
Phew, after many iterations, I think I have found a solution for `HdfsFileObject`. That class was confusing and broken, and I think it's better now - faster and thread-safe.
I agree that both features added are useful, but I find the protocol design rather clumsy. We have "save" which does one thing, and now we have "store" (a word...
Shared storage is only accessible with Java APIs, i.e. all file accesses need to be rewritten to be routed through JNI instead of using good old POSIX file APIs. And...
Please add documentation
Added another commit which fixes a data corruption bug with FT4232H chips. See https://github.com/XCSoar/XCSoar/issues/1031 for details