MaxFour
Please increase versionCode with each new release
Please increase versionCode whenever you release a new version. That is how Android tells updates. Currently, your app shows:
package: name='com.maxfour.music' versionCode='1' versionName='1.1.2' platformBuildVersionName=''
This being the 3rd release (according to releases/), it should at least have versionCode='3' for v1.1.2.
No reason to fix that for past builds – but please consider it for future ones :wink:
Thank you, Max! I've included your app with my repo, so folks who cannot/wantnot use Playstore can get it there using the F-Droid client. Thought about bringing it into the official repo, but it seems to use some proprietary dependencies (my library scanner reports "Google Play", most likely due to /com/android/vending/billing) which wouldn't be acceptable there.
PS: New versions will automatically be grabbed by my updater within 24h of your adding an .apk to a new tag – so people having it installed using the F-Droid client will also be notified of updates.
Don't forget to give me a ping then. Maybe we could go for the official repo with the proprietaríes removed?
@IzzySoft Hello! I released a new version with removed In-App billing dependency... Maybe we could go for the official repo?
Not before you finally remember to increase versionCode – the APK of the new version still has it set to 1, and hence it will never show up as update in any app store.
PS: Sorry for the delay, the cat ate the notification (mail didn't reach me) …
@MaxFour the last APK I checked still has it set to 1. And that was released after that commit. I'm confused. OK, the code at the tag matches – so here's the RFP.
Watch the linked issue. Within the next 24h, the F-Droid bot will perform an analysis and report it there. Might pop up some issue (often some "insecure gradle") which you then should take a look at and, if possible, fix (if you applied some fix, let me know and I trigger the bot to do a rescan).
I still wonder why the APK attached to v1.1.2.1 reports versionCode 1 if the code had fixed that before:
package: name='com.maxfour.music' versionCode='1' versionName='1.1.2.1' platformBuildVersionName=''
That makes auto-updating impossible in my repo (well, it wouldn't catch it anyway as the version compare only considers up to 2 dots in the version number – so all 1.1.2.* would be considered the same; from the 400 apps in my repo, yours is the first one using 3 dots), as two versions carrying the same versionCode are a conflict.
@IzzySoft OK, I understood you. Sorry for "dot" conflict 😔 In the next version, the version number will consist of 2 dots.
Much thanks!
Anytime! You couldn't know about the "too-many-dots" issue; 4 levels are not that unusual.
Please make sure the versionCode in the next APK is the correct one. Then I can set your app to auto-update in my repo (until it finally hits the official one and will be removed on my end).
PS: It seems it was not the 3 dots but the fact that the two versions have different number of dots (other apps with constantly 3 dots update fine). So feel free to decide whether keeping the 3 dots always, or 2 dots always :wink:
And it looks like the F-Droid Bot likes your repo: not a single warning. Now a dev must pick it up to integrate it. Fingers crossed, your app might pop up in the official repo before the month is over :wink:
@MaxFour just to let you know: My RFP (Request For Packaging) at F-Droid was just accepted, and the metadata have been merged. Which means, on one of the next build runs your app should be built there, and it should popup in the official repo shortly thereafter.
When that has happened, I usually remove the app from my repo (mainly to avoid confusion on updates, as both apps are signed with different keys they cannot be cross-updated which might shock novices). Just saying so you don't wonder. If for some reason you want me to keep your app in my repo at that point, please let me know in advance – exceptions are possible :wink:
Just to make sure you understand the consequences:
- pros: faster updates (usually about a week earlier)
- cons: the user would have to pick the "faster update" manually, as F-Droid will still recommend its own version as to be used. And even if applied manually, signatures clash if originally installed from the other repo.
I have no problems keeping it (I'm doing so for at least one other app for personal reasons, though I'm thinking about stopping that for above mentioned arguments), but for "the masses" I'd say it's not optimal. Think about it; a decision isn't needed before your app appears in the official repo. As said, no "bad feelings" either way – but as long as the official repo has it and keeps it updated, I'd suggest to have it only there (most of the apps being in both are in my repo only as F-Droid no longer updates them, because e.g. they started using non-free dependencies).
That's what I meant :wink: So I give it a few days overlap, and then remove it. I'll keep the metadata, though, so should the need arise it's reestablished easiliy, just let me know then.
And congrats (just got a notice on 86bec06db91039c9cfe68aacc3cdd48e8084789d) \o/
If you have other Android projects (I see some in this repo), remember you can bring them to F-Droid also. Just open a ticket and address me if you need help with this. I really enjoyed the process, was nice working with you!
Just a note, Max – the APK attached in releases/ gives:
package: name='com.maxfour.music' versionCode='1' versionName='1.1.2.1' platformBuildVersionName=''
Strange, thought that was fixed? The APK built by F-Droid correctly gives versionCode=4.
@IzzySoft Hi, sorry I did not answer for a long time, I was on vacation :) I will fix it in the next build!
Hi @IzzySoft ! I updated the application to v.1.2.0, can you publish it in the f-droid?
@MaxFour looks like it was picked up automatically (as it should). Thanks fr fixing – and sorry for the delay, I just returned from vacation …