FireFoxInvertColors icon indicating copy to clipboard operation
FireFoxInvertColors copied to clipboard

changing default shorcut

Open pasau opened this issue 7 years ago • 5 comments

How can i change the shortcut Alt+Shift+R to something else? i tried editing manifest.json, but firefox sees the extension as unsecure then.

pasau avatar Oct 18 '17 07:10 pasau

In chrome this can be done here: chrome://extensions/configureCommands

I am not sure of the Firefox equivalent

You can try to use the following addon: https://addons.mozilla.org/en-US/firefox/addon/keybinder/

Max-Github avatar Oct 19 '17 04:10 Max-Github

If you want to add an option for setting the shortcut on the preferences page, you are welcome to submit a pull request.

Max-Github avatar Oct 19 '17 04:10 Max-Github

I've added functionality for this. It will require merging my pull-request #15 first.

My branch is at:

https://github.com/iam-TJ/FireFoxInvertColors/tree/set_shortcut_key

But due to a lack of support in the Firefox web extensions API we cannot as-yet change the shortcut key assigned by the manifest.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1325692

iam-TJ avatar Feb 14 '18 02:02 iam-TJ

This is something that should be centrally controlled by the browser itself. As it is a given that there are/will be situations where keyboard bindings are going to clash.

So set_shortcut_key would allow users to have the default key binding, and what ever else they select. Am I understanding this correctly?

Max-Github avatar Feb 17 '18 10:02 Max-Github

The code - as I've written it - replaces the extension-set shortcut (since the default may conflict with other user shortcuts).

The upstream bug reports suggest the Moz devs are planning on a user interface for reviewing/controlling shortcuts, but also an extension API for changing the shortcut in a conflict-free manner.

I'll watch what happens and modify the changeset if necessary once the functionality lands in FF.

iam-TJ avatar Feb 17 '18 13:02 iam-TJ