duckdb_engine icon indicating copy to clipboard operation
duckdb_engine copied to clipboard

[Bug]: Struct and Map TypeEngine subclasses are missing type information

Open cpcloud opened this issue 2 years ago • 2 comments

What happened?

This is more of a feature request, but it appears that the Struct and Map types are missing type information, which makes them not so useful for type inference for duckdb inside of ibis. We have our own sqlalchemy types to deal with this, so it's not a huge problem at the moment, but I thought I'd raise it here.

DuckDB Engine Version

0.7.2

DuckDB Version

0.7.1

SQLAlchemy Version

1.4.48

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

cpcloud avatar May 18 '23 11:05 cpcloud

Heya,

I'd actually begun work on this after the PR yesterday already, so I'll put it up once it's ready (in the next few days hopefully), and see if it's fit for your purposes

Mause avatar May 18 '23 11:05 Mause

Sounds good!

cpcloud avatar May 18 '23 15:05 cpcloud