duckdb_engine icon indicating copy to clipboard operation
duckdb_engine copied to clipboard

build: test against sqlalchemy 2.0

Open Mause opened this issue 3 years ago • 1 comments

Mause avatar Oct 15 '22 04:10 Mause

Codecov Report

Merging #439 (7f0fe76) into master (a22f3bc) will decrease coverage by 33.62%. The diff coverage is 100.00%.

:exclamation: Current head 7f0fe76 differs from pull request most recent head d504958. Consider uploading reports for the commit d504958 to get more accurate results

@@             Coverage Diff             @@
##           master     #439       +/-   ##
===========================================
- Coverage   94.63%   61.02%   -33.62%     
===========================================
  Files           9        9               
  Lines         541      526       -15     
===========================================
- Hits          512      321      -191     
- Misses         29      205      +176     
Impacted Files Coverage Δ
duckdb_engine/tests/test_basic.py 38.57% <100.00%> (-60.92%) :arrow_down:
duckdb_engine/tests/test_pandas.py 54.68% <100.00%> (-40.40%) :arrow_down:
duckdb_engine/tests/test_datatypes.py 52.94% <0.00%> (-47.06%) :arrow_down:
duckdb_engine/tests/test_integration.py 60.00% <0.00%> (-40.00%) :arrow_down:
duckdb_engine/config.py 82.35% <0.00%> (-17.65%) :arrow_down:
duckdb_engine/tests/conftest.py 60.00% <0.00%> (-12.00%) :arrow_down:
duckdb_engine/__init__.py 78.57% <0.00%> (-9.29%) :arrow_down:
duckdb_engine/datatypes.py 97.14% <0.00%> (-2.86%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 15 '22 05:10 codecov[bot]

@Mause is there a timeline for releasing this?

sunank200 avatar Feb 01 '23 19:02 sunank200

Been using this PR for a week now and seems to work. Would like to see 2.0 support added.

mrjefftang avatar Feb 17 '23 19:02 mrjefftang

Been using this PR for a week now and seems to work. Would like to see 2.0 support added.

That's great to hear, thanks for trying it out! I'm back from holidays now, so I'll try to get an RC with this change out this week

Mause avatar Feb 21 '23 13:02 Mause