MaulingMonkey
MaulingMonkey
I added a git dependency to one of my projects: ``` wasm-dwarf = { git = "https://github.com/yurydelendik/wasm-dwarf", rev = "d5cd83df84d6709c079cf540f1217e559c47d66a" } ``` But it doesn't show up in `cargo crev...
Doing the initial review is only half the battle, keeping crates reviewed when new updates come out would be nice! My current workflow is to: * Review crate * Go...
(`@mooman219#0454` pointed this out to me on the community rust discord) In a release build, this will access out-of-bounds - the fn should likely be marked unsafe, or the debug_assert...
`jni_sys::jobject` and friends are simply raw pointers, whereas `jni::JObject` is generally assumed to be a valid object. This causes soundness problems if there are safe conversion methods from the former...
**Is your feature request related to a problem? Please describe.** It appears `cargo-about` will silently fail to generate license text for [`[[DEPPENDENCY.additional]]`](https://github.com/EmbarkStudios/cargo-about#dependencyadditional) tags which only specify `license-file` and not `license`....
https://github.com/jonasmr/microprofile-rust/blob/2746d44bbc40cbb32b9739e381590c21af025ebe/Cargo.toml#L8-L19 To comply with the terms of the license, "[src/microprofile/distorm/COPYING](https://github.com/gdabah/distorm/blob/39de02a118f95e254550a944843ee69f721c79d9/COPYING)", should probably be added to the include list. https://github.com/jonasmr/microprofile-rust/blob/2746d44bbc40cbb32b9739e381590c21af025ebe/Cargo.toml#L7 This should perhaps be: ```toml license = "MIT AND BSD-3-Clause AND...
One of the very first scopes I tried was: ```rust scope!("I/O", format!("class {}", file.name())); ``` Suffice it to say it didn't work terribly well when evaluated exactly once: https://github.com/jonasmr/microprofile-rust/blob/2746d44bbc40cbb32b9739e381590c21af025ebe/src/lib.rs#L189-L196 Of...
https://github.com/jonasmr/microprofile-rust/blob/2746d44bbc40cbb32b9739e381590c21af025ebe/src/lib.rs#L92 https://github.com/jonasmr/microprofile-rust/blob/2746d44bbc40cbb32b9739e381590c21af025ebe/src/lib.rs#L107 Having these take `html: impl AsRef` or `html: impl Into` would be convenient
**TL;DR:** Might be worth inserting `\0` after the escaped `v` on line 400 here: https://github.com/mxre/winres/blob/82f55f8b46ca7ac44971b6f14b5770ab5d65d8df/lib.rs#L396-L404 [MSDN Examples](https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource#examples) for VERSIONINFO resources appear to explicitly null terminate file/product version strings (`VER_FILEVERSION_STR` /...
- [ ] TryFrom? for super - [ ] TryFrom? for interfaces