PlayerInfo icon indicating copy to clipboard operation
PlayerInfo copied to clipboard

Wrong usage of return values for onCommand

Open robske110 opened this issue 7 years ago • 5 comments

return-ing false in onCommand should only be used if args are missing or something else where displaying the command usage would help the command executor to find out what he did wrong. But you're also returning false for player not found and permission problems.

robske110 avatar Oct 31 '17 17:10 robske110

Before I'm returning false in the perms and player I give them an error. Also with the args

Matthww avatar Nov 01 '17 10:11 Matthww

But because you are returning false the player gets another useless error

robske110 avatar Nov 01 '17 11:11 robske110

When I type command playerinfo, error applear...

XuPaperCup avatar May 25 '18 08:05 XuPaperCup

@XuPaperCup What is the error?

Matthww avatar May 26 '18 10:05 Matthww

It just say to ID and debug but now it ok

XuPaperCup avatar May 27 '18 23:05 XuPaperCup