Matthieu Dartiailh

Results 291 comments of Matthieu Dartiailh

The documentation includes Python examples and is written in such a way that it will be easy to add equivalent C++ examples and the API are so close that it...

Feel free to make a PR against the documentation. I only use kiwi through the Python bindings which may explain why the C++ side of things is missing.

What you describe is actually a ReadOnly member. The Constant member has a constant default value. Feel free to make a PR against the docs and examples.

I am also interested in bikeshedding the name of this member (we cannot just use Tuple for backward compatibility reasons): - SizedTuple - FixedTuple - ...

Does that fit what you had in mind @sccolbert ? PyErr_Print never raises a new error, so on this side we are safe but it does not gives a full...

We probably do not want to merge this before the next maintenance release planned mid-december. But this could use a review.

Actually this does lead to inconsistent states in enaml and I do agree with @sccolbert that an observer should not raise. Anyway I am not going to merge this as...

I don't see a way to make the decision on the observer since that would require to order then to be sure to call all the robust ones first. However...

I am not sure when I will come back to that, but I am less inclined to bare printing in particular because I fear it would break too much code....