MatthewFlamm
MatthewFlamm
Thanks for uploading the final thumbnail for this. I think it is ready for final review.
Thanks for the great reviews. This example is much better as a result.
> So my assumption is, that this patched function is not used in the test, but the original is called, which causes the try to connect via a socket. It...
I'm also not convinced based on the snipped tracebacks that you aren't calling the library after the config flow finishes. It could be that you are mocking this out correctly,...
Glad it worked out.
Looks like there are problems with trying to simultaneously handle the same file when downloading it or transferring it from the local vtk-data repo clone. We could consider using `--dist...
I do not quickly see any methods in vtk that would enable ~creating a new mesh~ modifying a mesh inplace by deleting cells entirely. The `extract_cells` method in pyvista would...
> `SetCells (vtkUnsignedCharArray *cellTypes, vtkCellArray *cells)` > Is it possible to implement @celltypes.setter for [UnstructuredGrid.celltypes](https://docs.pyvista.org/api/core/_autosummary/pyvista.unstructuredgrid.celltypes#pyvista.UnstructuredGrid.celltypes) in pyvista? This API as a whole needs reconsideration in my opinion, or at least...
I like the idea of the default interactor style being in the theme. Many interactor styles in PyVista can be customized, and the Enum approach doesn't allow for this usage...
As long as there is no breaking change likely it seems fine to me. Thinking this through I _think_ we could expose the CustomStyle in some form to allow this...