botman icon indicating copy to clipboard operation
botman copied to clipboard

This is my first set of updates to botman

Open mcsmpdot opened this issue 7 years ago • 5 comments

The goal was to have a smooth operational boot that presented data in it's interface in a way that made it easer to see what was going on.

By resolving errors, even if they weren't fatal reduced excess noise making it easer to tell when their is a real issue.

Performance issues and improvements to reduce code bloat due to repeated literals and to avoid large manual entry code dependencies which lead to errors inconsistencies and missed actions.

mcsmpdot avatar Jul 08 '17 10:07 mcsmpdot

Cool! I'll check it out. Thanks for this!

MatthewDwyer avatar Jul 08 '17 10:07 MatthewDwyer

Hmm.. I'm not sure if you are a patch behind but I see lines removed or changed that should not be. Also do not use math.random. If you want random numbers, use MySQL like I'm doing. Lua's random number generator is rubbish at randomness.

MatthewDwyer avatar Jul 08 '17 10:07 MatthewDwyer

Your commit is definitely a version behind. I'm seeing lots of reverted changes and other large missing chunks of code that need to be there.

MatthewDwyer avatar Jul 08 '17 11:07 MatthewDwyer

Also I used to have a lot more debug info written to Mudlet windows and that slowed the bot down too much. I removed 90% of them, especially in core areas like matchall.lua and gmsg_functions.lua. The bot sped up far beyond expectations. You can have debug output but you definitely don't want it there all the time. That is why I added the debug = false/true lines.

MatthewDwyer avatar Jul 08 '17 11:07 MatthewDwyer

I have downloaded your master from your fork and I will compare it to mine so I can merge some lines. I can't just merge it all as is because of the version discrepancy, plus the latest bot has changed significantly again (not published yet).

MatthewDwyer avatar Jul 08 '17 11:07 MatthewDwyer