EdgeOS-API icon indicating copy to clipboard operation
EdgeOS-API copied to clipboard

net5 Implementation

Open robfox92 opened this issue 3 years ago • 2 comments

Hi there, I've forked the project started porting it to net5.

What are your thoughts on bringing this project to net5? Do you think it's worth doing in one repository? Or is it best kept separate?

I was also wondering what your thoughts were around publishing a nuget package.

Cheers

robfox92 avatar Jun 03 '21 13:06 robfox92

Interesting, I'd been so tied up with maintaining existing applications at work I hadn't even realised there was a .NET 5!

I've researched and found:

"Additionally, we wanted to clearly communicate that .NET 5 is the future for the .NET platform." https://devblogs.microsoft.com/dotnet/introducing-net-5/

I think given .NET 5 is the future, this library hasn't had a lot of usage yet (I haven't finished the class walker for WebClient) and people can always retarget older frameworks for their needs it makes sense to adopt .NET 5.

Thanks will give it a go and commit.

Matthew1471 avatar Jun 05 '21 21:06 Matthew1471

I've made a partial go here, the main incompatibility was with the App.config files, and System.Web has been deprecated. Fortunately, the HttpUtility class has been renamed WebUtility and is still available.

I've not ported the config file changes, but it's on my todo list. I'll make a PR with the changes when I've done that, which should be over the next week or so.

robfox92 avatar Jun 07 '21 02:06 robfox92