PowerBI-ThemeTemplates icon indicating copy to clipboard operation
PowerBI-ThemeTemplates copied to clipboard

TypeScript Theme Definition?

Open phil-lgr opened this issue 3 years ago • 4 comments

I'm stumbling on this repo after looking at every piece of information we have from Microsoft on one of its flagship product (PowerBI).

Why on earth is there no official TypeScript package to describe the theming API?

So my understanding is that this page https://docs.microsoft.com/en-us/power-bi/create-reports/desktop-report-themes contains the sole source of truth regarding the Theme API?

Official TypeScript definition files should be versionned and published here: https://github.com/Microsoft/powerbi-models no?

At the very least, we should have a $schema definition to add to our theme json file?

Edit: here is the line where the Theme definition could be specified https://github.com/microsoft/powerbi-models/blob/master/src/models.ts#L1486

phil-lgr avatar Apr 22 '22 17:04 phil-lgr

Hey @phil-lgr! Thanks for opening your first issue. We appreciate your contribution to this project! One of our project maintainers will review this soon.

github-actions[bot] avatar Apr 22 '22 17:04 github-actions[bot]

Opened on ideas forum too... https://ideas.powerbi.com/ideas/idea/?ideaid=cead8d13-67c2-ec11-bea1-501ac50a5d5c I find it insane that this unofficial repo is the only place where we can have complete JSON examples

phil-lgr avatar Apr 22 '22 18:04 phil-lgr

@MattRudy if you can shed any light on this matter, I'd appreciate...

I'm actually writing my own .d.ts files to keep my sanity, the json you have are much better than the official doc

image

phil-lgr avatar May 05 '22 16:05 phil-lgr

@phil-lgr we're working on shipping a JSON schema to validate custom report themes in an upcoming release of PBI Desktop. If you shoot me an e-mail via my webpage "about me" page, I'll send ya a schema for you to try out. I'd be interested in your feedback.

yelper avatar Nov 01 '22 20:11 yelper