Matt Cowley
Matt Cowley
logs: https://github.com/cdnjs/logs/tree/prod/packages/i/ipaddr.js/2.0.1
Yeah, it definitely looks like we've somehow got the wrong hash calculated for it. I've confirmed observing the same as you, both the incorrect hash and what the correct hash...
Looping in https://github.com/cdnjs/cdnjs/discussions/14124 as it seems to be very related to this
👀 Ty for digging into this! I don't particularly feel that options 1 or 2 are overly viable. Choosing option 1 would essentially make the `basePath` component of our file...
Thanks for the further context. I agree that the simplest fix does seem to be to have the final file structure in an intermediate step before compression and SRI calcs....
I have asked internally again to see if I can get the correct :eyes: on this :)
@PeterDaveHello Chrome still does not have this implemented, should I raise this to Cf to ask them to set Cache control to be immutable when a Firefox UA is detected?
@MatthewSteeples Yeah, I think it best we implement it as it should improve performance. I will contact Cf and post any updates here :)
@xtuc would you be able to help with getting this added?
Currently, we send `cache-control: public, max-age=30672000`. Looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Caching_static_assets it should be safe to append `, immutable`. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Extension_Cache-Control_directives notes that if a UA doesn't recognize `immutable`, it should just be...