Matt Fenelon
Matt Fenelon
This looks great, thanks for looking at it. I won't be able to test it until Monday now. As you own _viewer.html, rather than change viewer.js, could you modify HOSTED_VIEWER_ORIGINS...
ActiveRecord::ConnectionTimeoutError "all pooled connections were in use" after enabling concurrency
Sorry to hear that @jkeen. I see you've reverted, that makes sense until we can clear this up. In terms of diagnosing: 1. What're your puma thread and workers set...
ActiveRecord::ConnectionTimeoutError "all pooled connections were in use" after enabling concurrency
The fact that it's locking up completely makes me think it's a deadlock related to the use of the Mutex. I've gone with a different approach in #472 but I...
ActiveRecord::ConnectionTimeoutError "all pooled connections were in use" after enabling concurrency
I think I've found the issue. It only seems to happen when side-loading children of child resources. Does that tally up with the side loading you're doing, e.g. `include=resource1.resource2(.resource3)+`? I...
ActiveRecord::ConnectionTimeoutError "all pooled connections were in use" after enabling concurrency
Sure I can do that. There's no (real) limit to the threads that the released version of graphiti can use. Instead the problem is that the unbounded threads eventually can...
> Still getting a lockup. This sounded possibly related: [ruby-concurrency/concurrent-ruby#933](https://github.com/ruby-concurrency/concurrent-ruby/issues/933) > > And it looks like graphiti only requires `concurrency-ruby ~> 1.0`, when really it should be ` > 1.2`...
I've added a failing test case that shows the deadlock: https://github.com/graphiti-api/graphiti/pull/472/commits/e4de93e5108ddefeff8d3f9639a1ca950dccbef8
@jkeen do you know how to get the rails tests to run locally? I'm struggling to debug the failures there. I've tried running: $ bundle exec appraisal install Which fails...
> @MattFenelon Sqlite is notorious for throwing build errors and I feel like I've spent countless hours of my life troubleshooting system-specific compilation errors with sqlite with ruby and node...
> @MattFenelon Are you pretty satisfied where this work is at now? I haven't tried it again in my staging or production app, just wanted to get your read on...