Matt-Yorkley

Results 73 comments of Matt-Yorkley

Nice summary! I think getting rid of all the complexity of `OptionTypes` and `OptionValues` will make this a lot easier (https://github.com/openfoodfoundation/openfoodnetwork/pull/10812). Finishing off the removal of master variants is definitely...

Hmmm I have a question about the `available_on` field as well: it doesn't change which products are shown in the shopfront, and it doesn't change which products are listed in...

Also as a side note, the `Spree::Variant` object doesn't have `created_at` or `updated_at` timestamps, which seems insane to me. We will definitely want to add them at some point, not...

On the `meta_keywords` attribute, it's partially used for searching/filtering results in the shopfront. I'm not sure it's necessary to move it to the variant in that case (or at least...

@kirstenalarsen I think the `available_on` thing is _potentially_ a very nice and useful feature, but the issue is that currently it doesn't actually work or do the things that the...

**Notes:** - Work on these two pages should be tackled in separate PRs - I'd probably prioritise `/admin/enterprises` first, as it gets 10-20 times more traffic and it should be...

There's a test failing with `uninitialised constant` for `MiniTest` in relation to this line: https://github.com/rack/rack-cache/blob/95a2c8bae62138dd0b93dc306181d7a2de01d32b/test/meta_store_test.rb#L185 Seems like that constant should have a lowercase `t` for the `Minitest` namespace? It's defined...

+100 This clear-all option is desperately needed!

If the response time on the shop pages is normally ~700ms, those anomalous 2-minute response times are likely taking place during a period where the server is under heavy load...

As a workaround, using `require` to explicitly load the classes that are used in the polymorphic associations works, but obviously it's not ideal...