string-template icon indicating copy to clipboard operation
string-template copied to clipboard

customize open/close tags via 'string-template/custom'

Open nenj opened this issue 10 years ago • 3 comments

The main module is now exposing two methods, 'process' (formerly 'template') and 'setOpenCloseTags' The one-function structure of module.exports is thus changed, maybe requiring a version increment... As you consider best, Matt.

nenj avatar Nov 18 '14 18:11 nenj

Coverage Status

Coverage decreased (-2.04%) when pulling eadd4de395bbbf0b5872ce3227b4e0c36e66f29e on nenj:master into 8f28bb1bc30ce9f29cb24273a9fbc76fe51d7a89 on Matt-Esch:master.

coveralls avatar Nov 18 '14 19:11 coveralls

I think it is good to be able to set the tags, but it probably should not be exposed like this. I suggest that we keep the same default expectation i.e. index.js exports a format function which defaults to '{' and '}'. Then maybe you can require string-template/custom to expose the tag options. index.js would rely on this underlying implementation.

Matt-Esch avatar Nov 18 '14 23:11 Matt-Esch

Coverage Status

Coverage remained the same when pulling edba0b90fa93f1990a3e1bbd383e51a58855cd62 on nenj:master into 8f28bb1bc30ce9f29cb24273a9fbc76fe51d7a89 on Matt-Esch:master.

coveralls avatar Nov 19 '14 16:11 coveralls