Tyler Breisacher

Results 40 comments of Tyler Breisacher

There's really nothing to test. If the package still builds successfully with the change, then the change is good.

I still have a PR out at https://github.com/aws-amplify/amplify-js/pull/9299 but I would love some guidance on what sort of testing is needed.

For renaming in particular I think this would work but there are other optimizations that are part of advanced mode where trying to apply the optimization to just _part_ of...

Can we remove the `setContinueAfterErrors` call at https://github.com/bazelbuild/rules_closure/blob/master/java/com/google/javascript/jscomp/JsChecker.java#L179 ? Generally an error such as a parse error should stop compilation immediately.

If @toneplex 's comment is correct then something like https://github.com/danrouse/react-audio-recorder/pull/29 should work (not tested yet!)

update: I tried the demo page with that fix and it seems to be working! :tada:

thanks, I think this should be good now :)

Here's one that's sort of similar to what happens to me from time to time. I don't know which chapter it would fit into best. You're on branch B1, and...

I'm happy to resolve conflicts if it will help get this merged!

@NilSet @jedwards1211 @julienw