openSMB2 icon indicating copy to clipboard operation
openSMB2 copied to clipboard
verified publisher icon Matriks404

Timing issues

Open Matriks404 opened this issue 7 years ago • 4 comments

  • [x] Timing in intro story is not correct (music ends too early, NES one ends just as last line of text appears.
  • [x] Physics and some graphics routines update separately and this is wrong! We should use delta time or something.
  • [ ] Check wether or not everything is timed correctly.

Matriks404 avatar Mar 04 '18 15:03 Matriks404

Just a note: we should compare recording of NES game and our engine and see what's wrong.

Matriks404 avatar Mar 31 '18 15:03 Matriks404

improved timing slightly in https://github.com/Matriks404/openSMB2/commit/72c6391da2937200c41071ba62dc5c7cb20ba4f1

Still incorrect though, it's hard to compare and measure results as my engine has constantly different timing (inconsistent framerate?). I will try to fix this later, with better computer.

Matriks404 avatar Apr 11 '18 09:04 Matriks404

It looks like VSync doesn't affect love.update (as it should), so timing is freaking wrong, we should compute everything in 1/60th of a second, and graphics could probably have VSync turned off.

Matriks404 avatar May 14 '18 21:05 Matriks404

Generally fixed in 70d74e8c812b5d76de9157b1f32b3949fe118fc0.

Matriks404 avatar May 18 '23 15:05 Matriks404