go_ehlers_indicators icon indicating copy to clipboard operation
go_ehlers_indicators copied to clipboard

Where is this smoothPeriod being used ?

Open quicksilverm25 opened this issue 4 years ago • 1 comments

https://github.com/MathisWellmann/go_ehlers_indicators/blob/bdc7bd10003cf6406a7e5da89427be5f8588cfb1/mama.go#L83

I was looking at the code closely and observed that Ehler's code at https://www.mesasoftware.com/papers/MAMA.pdf also has this line. However, my issue is that smoothPerioid isn't being used.

Do you think if this is a bug or am I missing anything here ? I was converting the code to python. If you know where the python impelentation may be present that would be great too.

But do let me know your thoughts around "SmoothPeriod" which make me feel somewhere we all have incomplete code.

quicksilverm25 avatar Apr 04 '21 13:04 quicksilverm25

Hi, You are correct, it is not used for anything in the original paper and therefore my code as well. I suppose it should be removed

MathisWellmann avatar Apr 07 '21 11:04 MathisWellmann