Extenject icon indicating copy to clipboard operation
Extenject copied to clipboard

Git tag (9.3.0) does not match package.json version (9.2.0)

Open krisrok opened this issue 3 years ago • 4 comments

Hard to keep track of the right version this way.

Also there are even more confusing some zombie files in this directory. Maybe they can be cleaned up? https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/

especially https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/Version.txt (saying 9.1.0) and another package.json: https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/package.json (saying 0.0.1)

krisrok avatar Jul 08 '22 08:07 krisrok

another problem is the file name too long for compositestaller in test folder

loverainstm avatar Jul 24 '22 08:07 loverainstm

@loverainstm

another problem is the file name too long for compositestaller in test folder

Is it for a limit of 260 characters?

https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows

tsgcpp avatar Jul 24 '22 10:07 tsgcpp

This could be easily solved, but what should the version in package.json be ? Should it be 9.3.1 (current last release) or 9.3.2 as the HEAD of this repo is currently not resolved ? @Mathijs-Bakker Do you have any guideline to follow for this ? It is true that it's a bit confusing in the editor view.

image .

ImInfenix avatar Nov 17 '22 19:11 ImInfenix

Yes, it should be current release.

I think it would be best if the semver is automated. As it's easy to forget to do this manually.

Need to check if there's a Github workflow for writing the semver into the project file.

Mathijs-Bakker avatar Nov 21 '22 20:11 Mathijs-Bakker