Mathieu Lamiot

Results 146 comments of Mathieu Lamiot

Checking first if we're on a cached page would probably be a little bit more efficient, especially for websites with a lot of visits. But the feature is working without...

Ok, we'd need a dedicated GH issue then I think. Thanks 🙏

On-going discussion about the screen size limitations: https://wp-media.slack.com/archives/CUT7FLHF1/p1713457206386399?thread_ts=1712752333.384509&cid=CUT7FLHF1

@Miraeld I am having an issue with this PR. It bails out when browsing on a 1920x1080 screen. I think this is because what we are measuring in the script...

> isn't the condition for it to be smaller than 1920x1080? That won't prevent the script from running on screens bigger 1920x1080, which would have more chances and give worst...

Some work is needed here on AC, to check with @Mai-Saad's [suggestion](https://www.notion.so/Beacon-Auto-optimize-LCP-image-Auto-exclude-images-above-the-fold-from-LazyLoad-56226bccec874b45aed4a57f08690029?d=cbe4c7fc135e4a8eab8c8f451a1d698e&pvs=4#97cd585220bd43c0814fe0463185bbcf): > can be: save optimized images (all types mentioned above) to the database, if any error occurs i.e...

This issue includes security checks like SQL injection and payload size to avoid to big DB footprint.

From @Mai-Saad [here](https://www.notion.so/Beacon-Auto-optimize-LCP-image-Auto-exclude-images-above-the-fold-from-LazyLoad-56226bccec874b45aed4a57f08690029?d=c799ac96fa6b45fc8de097e4e2f81fc0&pvs=4#4e4d9c1d3f694bd3941596ca1994c881): added the following AC, to be taken into account in the proposed solution: - Check that the beacon script is a minified JS file. - Check that...

> preload le homepage and extract internal links Not sure what this means and how it will be achieved 🤔 How do we identify the internal links from the homepage?...