Mathieu Lamiot
Mathieu Lamiot
@Miraeld Thanks for the first work on this. I left some comments and added a few things. Message to the whole team to keep working on this: https://wp-media.slack.com/archives/CUT7FLHF1/p1711450030697349
@Miraeld a few feedbacks: - I implemented built-in tests to cover the new/changed code. -> Seems that it disappeared from the checklist? I think new hooks should always have basic...
Discussed here: https://wp-media.slack.com/archives/CUT7FLHF1/p1709822793531749 Bringing back to grooming for now to investigate if the PHP approach will cover all cases for the SaaS or not.
Based on the results from https://github.com/wp-media/wp-rocket/issues/6408#issuecomment-1963671207, there is no need to further optimize for now.
Some work is needed here on AC, to check with @Mai-Saad's [suggestion](https://www.notion.so/Beacon-Auto-optimize-LCP-image-Auto-exclude-images-above-the-fold-from-LazyLoad-56226bccec874b45aed4a57f08690029?d=1d69da22a5a848e98097b94e905b0ba9&pvs=4#5f6f2345124f4814a83db5f40d4e458a): > beacon will check if the screen size is acceptable one to prevent generating data for weird screen...
We should have AC / task about measuring the script execution time, especially on pages with a lot of images to ensure we remain efficient and optimized.
I am adding this task to the service team sprint as disucssed during sprint planning, so that @mostafa-hisham can share his feedbacks on what needs to be improved from the...
Thanks @mostafa-hisham. I see there are points to be discussed with the Product team ; can you raise this point to them directly on Slack and share the discussion here...
@piotrbak According to the graph, the check about data being already here or not should be by-passed in case we are not on a cached page. I am not sure...
Follow-up on this @piotrbak: https://github.com/wp-media/wp-rocket/issues/6432#issuecomment-2020309717 Currently, the check to the DB if there is already or not LCP/ATF images, or if there is a failed row is done all the...