Mathieu Lamiot
Mathieu Lamiot
Closing the PR for now as we don't want to change anything compared to the current behavior.
Should this PR be made a real PR and not a draft? As I see it's "Ready for review". Thanks!
AC 1 & 3 would need to be refined I believe, that's quite free to interpretation here. We would really need examples to reproduce, otherwise we won't be able to...
I guess there are 2 ways of handling those exceptions: preventing them to be identified in the first place as candidates, or filter out before storing in DB some given...
Thanks @wordpressfan ! The safeguard/bail-out with elementInfo and empty( $image->type ) look OK to me. My main concern is about: > $image_src_filetype_array = wp_check_filetype( $image_src_path ); > return ! empty(...
@DahmaniAdame so this URL should not make it to the DB? http://1.gravatar.com/avatar/d7a973c7dab26985da5f961be7b74480?s=120&d=mm&r=g on http://mathieu.e2e.rocketlabsqa.ovh/hello-world
CDN exploratory test results reported [here](https://wp-media.slack.com/archives/CUKB44GNN/p1714472889428719?thread_ts=1714029856.799009&cid=CUKB44GNN)
Might be related to https://github.com/wp-media/wp-rocket/issues/6339?
@piotrbak about the expected behavior here, I see three possibilities: - Keep the special characters so that the feature works as expected OR - discard images with special characters from...
If there is an easy and safe way to go with 1, sure let's go there. From what I got, it is mostly about avoiding sanitization and just doing escaping?...