Mathias Picker

Results 84 comments of Mathias Picker

> > But if i get it right, doing the `e.preventDefault` on this error will not solve the issue, but just silence it? > > Yes, that's right. The real...

> > We are using the node-adapter, and we have skew-protection enabled in our Vercel settings. The users that experience this issue will not see the error page, instead the...

We've had progress on reproducing the `Failed to fetch dynamically imported module` issue consistently. Read https://github.com/sveltejs/kit/issues/12592 for more info 👍

Shouldn't the rotation be computed from the `from` state to the `to` state? It seems like this just sets the rotation to some arbitrary number.

> Yesterday I've updated us to 5.43.8 and we've got page freezing reports. There also were some problems with flip animation. So definitely something with each block refactoring isn't backward...

> So you must have had "w-fit w-full" applied on the same component, right? Seems like a svelte class chaos Yes, correct. However, I tried creating a repro with the...

> About `getTextInRange` and `getLineAtPosition`. These two functions were often called with `Document` and `DocumentSnapshots`. Both should already have a cache of `lineOffsets`. It should be possible to go further...

Also, have you checked my other PR's? - https://github.com/sveltejs/language-tools/pull/2900 - https://github.com/sveltejs/language-tools/pull/2899 - https://github.com/sveltejs/language-tools/pull/2898 Would love feedback on them as well!

I have managed to find something interesting. The `updateIfDirty` call in `lsContainer.getService` seems to be a bottleneck on the "initial load" for intellisense in Svelte files. It almost always takes...

> When the language server starts, TypeScript will create a "program" object that contains type information about the project. The `updateIfDirty` function is mostly a wrapper around `ts.LanguageService.getProgram` to ensure...