DashCoin icon indicating copy to clipboard operation
DashCoin copied to clipboard

versionCode is not increased

Open IzzySoft opened this issue 3 years ago • 4 comments
trafficstars

While your latest release is tagged v1.1.0, your build.gradle still has versionCode:1 and versionName: "1.0". Could you please adjust that for future releases? For some background:

  • versionCode: what Android uses to tell versions apart. Two APKs with the same versionCode are considered being the same. No update notification/offer will be made. So today's update reached my repo, but existing users won't notice :scream:
  • versionName: what the user gets to see. If that stays the same, users can never tell which version they're running. Not only bad for their updates, but also for their issue filings :wink:

Thanks in advance for taking care!

IzzySoft avatar Aug 25 '22 20:08 IzzySoft

Hello @IzzySoft Thank you for the issue, i totally forgot to change it 😥 i'll try to release soon with the update, take care dude

MathRoda avatar Aug 26 '22 19:08 MathRoda

Thanks! Then it'll solve itself with the update. And if you remember in the future, the issue won't arise again :stuck_out_tongue_winking_eye:

IzzySoft avatar Aug 26 '22 20:08 IzzySoft

hahah I'll sure do

MathRoda avatar Aug 27 '22 15:08 MathRoda

MayI remind you to do it "really sure? Your latest release (from August 25) still confusing my updater, as it still identifies with a version not matching the tag name: tag = v1.1.0, app = v1.0 and versionCode: 1. I'll hence now have to disable update checks. Please give me a ping when a fixed release is available. Thanks!

IzzySoft avatar Oct 23 '22 23:10 IzzySoft

Well, I doubt it will ever be done. Updates are disabled for your app in my repo until solved. Please give me a ping then so I can check and re-enable them, @MathRoda

IzzySoft avatar Feb 04 '23 00:02 IzzySoft

@IzzySoft #49

MathRoda avatar Mar 26 '23 13:03 MathRoda

Thanks! Will the next release have a signed APK attached again then? v2.0.0 only has an app-release-unsigned.apk. Then I may hopefully re-enable updates for my repo.

IzzySoft avatar Mar 26 '23 14:03 IzzySoft

Hi @MathRoda, sad news. I had to remove DashCoin from my repo for now. Not because the APK at the latest release (v2.3.0) still/again does not match its versionName (2.2.0) and thus auto-updates fail, but because of

Offending libs:
---------------
* Play Services SafetyNet (/com/google/android/gms/safetynet): NonFreeComp,NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Google App Engine (/com/google/appengine): NonFreeNet
* Cloud Audit Logs (/com/google/cloud/audit): Tracking
* Google Cloud Logging Client for Java (/com/google/cloud/logging): NonFreeNet
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* firebase-firestore (/com/google/firebase/firestore): NonFreeDep,NonFreeNet

7 offenders.

That exceeds the numbers tolerated in my repo, so I can no longer keep it up there. Should you have a "liberated" build available, I gladly see that I can re-establish it, just let me know then – but for now, with the next sync around 7 pm UTC it will disappear from my repo. Sorry for that.

IzzySoft avatar Dec 03 '23 19:12 IzzySoft