Mateus Stano Junqueira
Mateus Stano Junqueira
Awesome! This is finally ready to be merged. Probably the biggest PR we ever had, and we never make anything as big as this again heheheh
> Trying to build the docs here... look what I've got: This seems to be due to `terminate_on_apogee` making the simulation stop before calling the extra udot with post processing....
@Gui-FernandesBR ready for a new review! > This PR may present a conflict with the #581 , given that both deal with the postprocessing methods. > I think we might...
@Gui-FernandesBR its ready
Hey! So I have changed the way the sensors readings. The initial implementation had the measurements saved in the sensor object being used, this caused the following problems: 1. If...
> Seems like we have an inverted direction somewhere: >  This result is supposed to be right because the noisy gyroscope is upside down. Please check the orientation and...
> Also I did not care so much about the new jupyter notebook, I think it is there as a fast testing option only, right? Yes, its just for testing...
Incredible PR with really necessary changes. Just want to point out that most commits and the whole PR is not a Maintanence (MNT) type, but Enhancement. Most commits change the...
> * Is there any numerical integration scheme faster than LSODA? It seems to be taking around 60% of the simulation time. Plus it cannot be parallelized. There might be...
> I even added a new if statement to force the code to use the old `u_dot` method in case the rocket motor is a SolidMotor. This might be breaking...