OPTIMADE icon indicating copy to clipboard operation
OPTIMADE copied to clipboard

Add extra schema checker jobs to CI

Open ml-evs opened this issue 2 months ago • 3 comments

Closes #575

I've also tweaked some of the rst roles in the spec to maybe allow us to scrape the spec for all fields (in a2cb422). It might be worth adding some special role to the headers that define fields to make this even easier, otherwise I'll concoct some grep incantation to try and do the same job without needing any changes to the spec.

ml-evs avatar Nov 07 '25 15:11 ml-evs

This PR now has a checker for:

  • building an validating existing schemas in CI
  • scraping the spec for property names and checking they have schemas (to be replaced eventually when we generate the spec from the schemas themselves) -- currently failing as we await trajectories fields.

ml-evs avatar Nov 16 '25 23:11 ml-evs

After the meeting we decided to remove the blocking-release label from this PR -- I'm wondering if instead I should merge in the "uncontroversial" part which is just calling the make schemas tool in our CI, and leave the other "checking for fields in the spec that don't have definitions" part for a future PR.

ml-evs avatar Dec 07 '25 15:12 ml-evs

After the meeting we decided to remove the blocking-release label from this PR -- I'm wondering if instead I should merge in the "uncontroversial" part which is just calling the make schemas tool in our CI, and leave the other "checking for fields in the spec that don't have definitions" part for a future PR.

Splitting off uncontroversial make schemas part sounds like a good idea to me!

merkys avatar Dec 08 '25 07:12 merkys