materialize icon indicating copy to clipboard operation
materialize copied to clipboard

Bump Rust version to 1.74.1

Open def- opened this issue 1 year ago • 1 comments

Fixes: https://github.com/MaterializeInc/materialize/issues/24818 Release notes: https://releases.rs/docs/1.74.1/ The fix we need for aarch64 compilation is https://github.com/rust-lang/rust/pull/118464

Checklist

  • [ ] This PR has adequate test coverage / QA involvement has been duly considered.
  • [ ] This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • [ ] If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • [ ] This PR includes the following user-facing behavior changes:

def- avatar Feb 16 '24 15:02 def-

Disabling auto-merge because of @ParkMyCar's comment.

nrainer-materialize avatar Feb 16 '24 15:02 nrainer-materialize

You should also bump the NIGHTLY_RUST_DATE

Unless I'm missing it this could still use a bump. I think it's fine to defer that bump until the 1.76 bump though.

benesch avatar Feb 19 '24 15:02 benesch

Indeed. I tried bumping the nightly version but that failed because of various reasons, so I tried a few versions inbetween, but they all fail for some reasons. Fixing the newest version will require a new version of nextest to be released, so I didn't want to block this since rustc is still panicking and making CI slightly annoying.

def- avatar Feb 19 '24 15:02 def-

Yup makes sense! Removing the ARM segfaults seems more important.

benesch avatar Feb 19 '24 16:02 benesch