materialize icon indicating copy to clipboard operation
materialize copied to clipboard

testdrive: use a useful Postgres default image

Open maddyblue opened this issue 2 years ago • 4 comments

mzcompose's default Postgres image uses postgres 10 due to some mzbuild stuff that seems unused now. Remove the mzbuild stuff for Postgres and just make it always use a recent version.

Motivation

  • This PR fixes a previously unreported bug.

Checklist

maddyblue avatar Aug 05 '22 03:08 maddyblue

SET WITH OIDS has apparently gone away, and I'm not sure what it was trying to do or how I should fix it:

As oid system columns cannot be added anymore, this never has an effect.

https://www.postgresql.org/docs/14/sql-altertable.html

maddyblue avatar Aug 05 '22 04:08 maddyblue

Hard coding an older postgres for pg-cdc which seems to have needed it until someone else can look at the specifics.

maddyblue avatar Aug 05 '22 04:08 maddyblue

That fixed a few errors. Not sure about the conflict_schema stuff. Might look more later.

maddyblue avatar Aug 05 '22 04:08 maddyblue

If we are no longer using mzbuild with Postgres we should also remove misc/images/psql to avoid any confusion.

philip-stoev avatar Aug 05 '22 16:08 philip-stoev

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 08 '22 17:12 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 08 '22 17:12 CLAassistant