MaterialDesignInXamlToolkit icon indicating copy to clipboard operation
MaterialDesignInXamlToolkit copied to clipboard

fixes #3654 - NumericUpDown not focusable by pressing tab

Open corvinsz opened this issue 1 year ago • 2 comments

set IsTabStop to False on the default NumericUpDown control style

corvinsz avatar Aug 21 '24 17:08 corvinsz

removed setting IsTabStop again. Instead added an eventhandler for GotFocusEvent to move the focus to the PART_TextBox when the NumericUpDown has gotten focus.

When the control gets focused, all the text of the PART_TextBox gets selected via SelectAll(). It's debatable if that should be a thing or not. I decided to go with it because that's how the default WPF DatePicker handles it.

corvinsz avatar Aug 22 '24 18:08 corvinsz

Hey @corvinsz, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #3656

https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/pull/3656

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

Keboo avatar Aug 29 '24 06:08 Keboo

This PR is marked stale because it has been open 60 days with no activity. Remove stale label or update the PR, otherwise it will be closed in 14 days.

github-actions[bot] avatar Oct 29 '24 02:10 github-actions[bot]