MaterialDesignInXamlToolkit icon indicating copy to clipboard operation
MaterialDesignInXamlToolkit copied to clipboard

Add method overload for ShowDialog extension with identifier

Open Myliak opened this issue 10 months ago • 3 comments

Is your feature request related to a problem? Please describe. It's rather simple problem, when iterating through xaml object tree, it would be nice to define identifier which must be on found DialogHost, so if multiple are present, it chooses correct one

Describe the solution you'd like Create an overload method that accepts string identifier, exactly as is in DialogHost.ShowDialog

Describe alternatives you've considered I don't think there are any, except for using only one dialoghost (so I take this as low prio)

Myliak avatar Mar 26 '24 09:03 Myliak

Could you explain a bit better what you'd like to be added? The code in DialogHost.Show(...) already accepts an identifier. I think I'm missing some information.

MichelMichels avatar Mar 31 '24 21:03 MichelMichels

No problem, there are two variations of how to open Dialog window in code:

  1. DialogHost.Show(...) as you said - Wiki
  2. .Show(...) Extension, which does not have the identifier overload - Wiki

The second one is the one I would like to add overload to :)

Myliak avatar Apr 02 '24 07:04 Myliak

This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.

github-actions[bot] avatar May 03 '24 01:05 github-actions[bot]

This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.

github-actions[bot] avatar Jun 03 '24 01:06 github-actions[bot]

@Myliak I submitted a PR. Would you check if this adds the functionality you need?

MichelMichels avatar Jun 14 '24 19:06 MichelMichels