MaterialDesignInXamlToolkit Uniform style in demo app pages

I'm reviewing the demo app pages to create a more uniform style and fixing some minor style issues.

Pages:

[X] Buttons
[X] Cards
[X] Chips
[X] Color Tool
[X] Colour Zones
[X] ComboBoxes
[X] Data Grids
[x] Dialogs
[x] Drawer
[x] Elevation
[x] Expander
[x] Fields
[x] Fields line up
[x] Group Boxes
[x] Icon Pack
[x] Lists
[x] Menus & Tool Bars
[x] Navigation Rail
[x] Palette
[x] Pickers
[x] Progress Indicators
[x] Rating Bar
[x] Sliders
[x] Snackbar
[x] Tabs
[x] Toggles
[x] Transitions
[x] Trees
[x] Typography

Other:

[X] Documentation links in header VerticalAlignment = Center for TextBlock

Nov 14 '22 07:11 MichelMichels

I thought the wrapping issue was fixed but it's not. I haven't checked all views but I can say that Card and Elevation views are not wrapped compared to the old versions See: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/discussions/2862 It would be nice to fix that

Nov 16 '22 09:11 ElieTaillard

@Xaalek could you clarify what behavior is desired? Do you mean WrapPanel style wrapping?

Atm the Cards page gets a horizontal and vertical scrollbar when the windows size is too small for the content (see screenshot below).

Nov 16 '22 09:11 MichelMichels

@Xaalek The issue is in MaterialDesignDemo.Domain.DemoItem.

private ScrollBarVisibility _horizontalScrollBarVisibilityRequirement = ScrollBarVisibility.Auto;
private ScrollBarVisibility _verticalScrollBarVisibilityRequirement = ScrollBarVisibility.Auto;

The default horizontalscrollbarvisibility should be ScrollBarVisibility.Disabled in my opinion. When I set it manually on the demoitem for the cards page, this works as intended.

@Keboo can I change this default value? Horizontal scrolling for a desktop app doesn't seem intuitive to me, but maybe this is a personal preference.

Nov 16 '22 10:11 MichelMichels

In the old versions of the demo, views was wrapped Old (4.5.0): New (last):

Nov 16 '22 10:11 ElieTaillard

In the old versions of the demo, views was wrapped Old (4.5.0): (...)

@Xaalek I fixed it in one of the previous commits.

Nov 18 '22 20:11 MichelMichels

@MichelMichels yes feel free to change the default.

Nov 19 '22 05:11 Keboo

@MichelMichels yes feel free to change the default.

Thanks! But in the meantime I found out that it's better to leave it this way and change it on specific pages where it's needed.

Nov 19 '22 07:11 MichelMichels

Better late than never I guess. Ready for merging with master!

May 17 '23 21:05 MichelMichels