MaterialDesignInXamlToolkit icon indicating copy to clipboard operation
MaterialDesignInXamlToolkit copied to clipboard

Broken Flipper

Open ElieTaillard opened this issue 3 years ago • 0 comments

Bug explanation

The flipper seems broken in the 4.5.0.

Here are the bugs I noticed:

  • The Flipper has lost its "Card" appearance: missing elevation, missing border
  • The Filpper has a strange behavior in the demo app like mention here: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/2577
  • The background Flipper does not change color when changing theme (dark and light) like mention here: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/694

These bugs can be observed in the demo application.

image

image

https://user-images.githubusercontent.com/54487782/171450322-950edc9f-8e27-47db-839d-d8b3143ff5de.mp4

It would be nice to take a look at these different problems because currently the Flipper is not very usable.

I quickly checked the code but I didn't see anything shocking. The only things I noticed were the following:

  • The Flipper style is not dynamic in the demo app https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/master/MainDemo.Wpf/Cards.xaml#L341
  • The ShadowAssist class is not declared static https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/master/MaterialDesignThemes.Wpf/ShadowAssist.cs#L43

Version

4.5.0

ElieTaillard avatar Jun 01 '22 16:06 ElieTaillard