MaterialDesignInXamlToolkit icon indicating copy to clipboard operation
MaterialDesignInXamlToolkit copied to clipboard

Transition animation appears blank

Open Case-Closed-X opened this issue 3 years ago • 4 comments

Bug explanation

After a quick click of two buttons, the transition animation appears blank as shown in the video. I'm not sure it's a problem.

Version

4.5.0

https://user-images.githubusercontent.com/50199528/170613627-0b700fb9-e193-481d-a09f-ebe1a91e950c.mp4

Case-Closed-X avatar May 27 '22 01:05 Case-Closed-X

Hello, yes it's a problem related to animations in transitions. I think need to look deeper to understand where animations are overlapping. As a result we have blank page when user click very fast

Erapchu avatar Jun 01 '22 14:06 Erapchu

We set opacity to zero when animations completed. I can prepare changes. As fast fix you need to decrease animation duration

Erapchu avatar Jun 01 '22 14:06 Erapchu

I can reproduce described behavior in Transitions menu in Demo app just by pressing left/right arrows on keyboard.

Do we really need to set opacity explicitly to zero in CircleWipe: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/3de22172ce4ec50e7d7416e5fd34806d7e415381/MaterialDesignThemes.Wpf/Transitions/CircleWipe.cs#L46 https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/3de22172ce4ec50e7d7416e5fd34806d7e415381/MaterialDesignThemes.Wpf/Transitions/CircleWipe.cs#L55

and SlideOutWipe: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/blob/3de22172ce4ec50e7d7416e5fd34806d7e415381/MaterialDesignThemes.Wpf/Transitions/SlideOutWipe.cs#L38

after animations completed? Those events are follow each other and they can setup opacity unpredictable. I think we can remove set opacity in events, anyway it should be done by animations?

Erapchu avatar Jun 02 '22 02:06 Erapchu

Seems to be an old issue https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/975 https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/939 https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/1130

ElieTaillard avatar Jun 22 '22 07:06 ElieTaillard