MaterialDesignInXamlToolkit icon indicating copy to clipboard operation
MaterialDesignInXamlToolkit copied to clipboard

Breaking 5.0.0 Changes

Open Keboo opened this issue 4 years ago • 2 comments

There is an existing 5.0.0 branch where these changes are being made. Once we are a little closer to the release this branch will be merged into master. Anyone is welcome to pick up tasks here and PR into the 5.0.0 branch.

This is a list of proposed breaking changes for the 5.0.0 release. Feedback welcome!

  • [x] Remove DrawerHostOpenMode.Model (Added in 4.0.0, Obsolete in 4.1.0)
  • [x] Remove MaterialDesignScrollBarThumbVertical and MaterialDesignScrollBarThumbHorizontal replace with MaterialDesignScrollBarThumb
  • [x] Consider making recommended theme color classes static.
    • Currently not possible because they implement the ISwatch interface.
  • [x] Update ListBoxItem to use theme brush for hover color rather than deriving from the Foreground.
  • [x] Update MenuItem to use theme brush for hover color rather than deriving from the Foreground.
  • [x] There is a both usage of "Assist" and "Extensions" used. Consider standardizing on naming
  • [x] Remove MaterialDesignRaisedAccentButton in favor of MaterialDesignRaisedSecondaryButton
  • [x] Remove MaterialDesignFlatAccentButton in favor of MaterialDesignFlatSecondaryButton
  • [x] Remove MaterialDesignFlatAccentBgButton in favor of MaterialDesignFlatSecondaryMidBgButton
  • [x] Remove MaterialDesignFloatingActionMiniAccentButton in favor of MaterialDesignFloatingActionMiniSecondaryButton
  • [x] Remove MaterialDesignFloatingActionAccentButton in favor of MaterialDesignFloatingActionSecondaryButton
  • [x] Remove ComboBoxPopupPlacement
  • [x] Remove obsolete members from ComboBoxPopup
  • [x] Remove obsolete templates PopupContentUpTemplate and PopupContentDownTemplate
  • [x] Remove obsolete brushes #2435
  • [x] Replace usages of "Accent" with "Secondary"
  • [x] Remove "MaterialDesignNavigatilRailTabControl" it is replaced by "MaterialDesignNavigationRailTabControl"
  • [x] Remove RatingBarButton.IsWithinSelectedValue property
  • [x] Remove obsolete members from FlyoutAssist
  • [x] Remove ShadowDepth
  • [x] Remove ShadowAssist.ShadowEdges
  • [x] Rename ShadowEdgeConverter to ShadowOpacityMaskConverter to better reflect its usage
  • [x] Ensure all styles and brushes that contain the word "Accent" have been replaced with "Secondary"
  • [x] Remove PickerInnerPaddingConverter (obsolete in PR #3181)
  • [x] Rename all *Mixin classes to be *Extensions
  • [x] Remove MaterialDesignTheme.Defaults.xaml in favor of people using either MaterialDesign2.Defaults.xaml or MaterialDesign3.Defaults.xaml
  • [x] Ensure all removed obsolete styles exist in the Obsolete shim resource dictionary.

Keboo avatar Feb 19 '21 06:02 Keboo

Might be good to add "Remove ShadowDepth" here. Context: #2786

jizc avatar Jul 19 '22 13:07 jizc

I'm in favor of dropping the netcoreapp3.1 target framework moniker as it reached it's end-of-life on December 13th, 2022. I'll make a pull request for it.

MichelMichels avatar May 18 '23 06:05 MichelMichels