JOKer

Results 28 comments of JOKer

In my opinion, the game loses charme when texture filtering is enabled. (And that stone deposit or whatever looks like it's from another world in both pictures.) Looking only at...

Fife supports both python3 and python2. They cannot enforce python3. UH needs python3 module for fife, though.

Additionally, fife's python support is only an added feature (via swig). Fife itself is written in C++ and needs to be compiled using cmake. I don't think `python setup.py build`...

Maybe the best solution would be removing the `networkclient.py`? I haven't checked, when the `horizons.network.client` disappeared, but at least since then, the file has not been run by anyone ...

If I understand it correctly, this refers to e.g. making a trade in the background or having resources produced or something like that, while the tab is open.

I've read in an article about mypy, that one should start with getting '--check-untyped-defs' running and then continue to add explicit typing to the rest of the code, once this...

If I understand it correctly, one can do something along the lines of `if False: import bla`. It's mentioned in the article you linked for python2 code. Although `typing.TYPE_CHECKING` seems...

Did mypy's gitter turn up with a solution?

"Including it in the package" sounds like `horizons.ext` to me.

IIRC we don't need it at runtime, so the better way for packaging would be to patch all the imports out of the project. As you said, it's only for...