tidal-hifi icon indicating copy to clipboard operation
tidal-hifi copied to clipboard

Question regarding MPRIS

Open fijar-lazuardy opened this issue 1 year ago • 8 comments

If I play a video, tidal will shown as "chromium.instance" instead of "tidal-hifi" is it a bug?

fijar-lazuardy avatar Jul 08 '24 14:07 fijar-lazuardy

Hey @fijar-lazuardy,

Yes it is. We've been having a hard time removing "chromium.instance" and other chromium-related names in various places. Removing it often means disabling parts of the browser as well, which would have adverse affects on the player.

I'll have a look when I can to see if this one is an easy fix though.

Mastermindzh avatar Jul 10 '24 06:07 Mastermindzh

no worries, it's not bothering or anything

fijar-lazuardy avatar Jul 11 '24 03:07 fijar-lazuardy

@fijar-lazuardy

I just checked and it works as expected. I can successfully play/pause media using:

playerctl play-pause tidal-hifi to play and pause the videos.

I also found the following:

  • playerctl -l doesn't always seem to list tidal-hifi, but even if not listed it does still work
  • when you start tidal with a video preloaded, the addMpris function doesn't seem to execute, gotta look into that (bug)

Please tell me the steps you used to identify this 😄

Mastermindzh avatar Jul 15 '24 10:07 Mastermindzh

the addMpris function does set up a player but it isn't hooked up to the video player. That seems to be a TIDAL thingy for now but might be fixed with the new API.

For now there doesn't seem to be anything I can do.

Mastermindzh avatar Jul 15 '24 11:07 Mastermindzh

Nice to hear and thanks for checking this! I'll try when I get home and put the result here

fijar-lazuardy avatar Jul 15 '24 11:07 fijar-lazuardy

System OS: Linux Mint 21.3 x86_64 Kernel: 5.15.0-91-generic Packages: 2185 (dpkg) Shell: zsh 5.8.1 DE: Xfce 4.18 WM: Xfwm4 Terminal: kitty CPU: AMD Ryzen 7 5700X3D (16) @ 3.000GHz GPU: AMD ATI 2d:00.0 Device 73ef Memory: 6903MiB / 32012MiB tidal-hifi version: 5.14.1

case 1: image

playerctl -l

play video and run

playerctl -l

again does not update MPRIS image

case 2: play video right after tidal opened image

fijar-lazuardy avatar Jul 16 '24 06:07 fijar-lazuardy

Ah!

I didn't check wether metadata is updated.... I only checked controls (e.g. play). It makes way more sense that the data wouldn't be updated correctly though (I never looked at video support)

Thanks for the testing!

Mastermindzh avatar Jul 16 '24 08:07 Mastermindzh

Somewhat unrelated, but this will also happen on occasion as I'm skipping songs - often it will correctly begin as tidal-hifi, but after some skipping, my statusbar which uses playerctl to track tidal-hifi will stop updating (I also stop receiving notifications from dunst) and using playerctl afterwards will still list tidal-hifi, but with the metadat of some previous song, whereas there will some chromium instance which lists the actual current song. Not certain if this occurs only while I skip songs, or if it happens naturally during track progression. Sometimes it will correct itself, but not certain how to cause "corrections" on demand.

mitteneer avatar Aug 02 '24 22:08 mitteneer