html5-php icon indicating copy to clipboard operation
html5-php copied to clipboard

Get rid of libxml dependency

Open alecpl opened this issue 6 years ago • 4 comments

I don't see anything in the code that would require libxml extension. We only need DOM. Do I miss something?

alecpl avatar Nov 20 '19 18:11 alecpl

I see utf8_decode(), but preceded with function_exists() check, so composer.json should not require libxml.

alecpl avatar Nov 20 '19 18:11 alecpl

I think that here the intention was to require ext-dom. Probably is a bug. (even if having ext-dom implies installing libxml...

I will be happy to change it. Can you reproduce it somehow on travis ci? removing libxml, but keeping extdom?

goetas avatar Nov 22 '19 16:11 goetas

No, I didn't try with Travis, that came from one of Roundcube users.

alecpl avatar Nov 25 '19 06:11 alecpl

Actually, the ctype ticket came from the user. This one is from me just reviewing dependencies.

alecpl avatar Nov 25 '19 06:11 alecpl