Matthew Peveler
Matthew Peveler
Oh I see, you're talking about the [`PdoAdapter::migrated`](https://github.com/cakephp/phinx/blob/a6fe385da2214db3a3c1edfa96ffb5432467efd5/src/Phinx/Db/Adapter/PdoAdapter.php#L506-L539) function. You're envisioning modifying the insert to be something like: ```php $sql = sprintf( "INSERT INTO %s (%s, %s, %s, %s, %s)...
I think that just doing alias for column on fetch would be best as I agree that requiring to use quotes on all usages of the columns (including inserts/updates) would...
For this ticket, I feel like it might make sense to remove the function documentation from `porfinder.js` and have it purely live in `portfinder.d.ts`, where at this point I think...
See https://github.com/actions/add-to-project/blob/main/.github/workflows/check-dist.yml as an example of requiring people that create PRs to also update the `dist/` files in their PR, or else would get a failing check. While this is...
We got bit by this in our application recently where we were passing the response from a gRPC response through [camelcase-keys](https://www.npmjs.com/package/camelcase-keys), where when we got something like `{ msg: 'foo',...
Postgres has the following to override using the `public` schema: https://github.com/cakephp/phinx/blob/a093a9635ca8882ae3edc4b8d5da4d4fa750481f/src/Phinx/Db/Adapter/PostgresAdapter.php#L1548-L1553 Can add a similar function to SqlServerAdapter and anywhere it uses `$this->schema`, then use `$this->getGlobalSchemaName()` instead. Though, I think...
Hm, actually, won't be quite as simple, as I don't think sqlserver has the same concept as postgres in terms of being able to set a `search_path` that affects all...
The `actions/setup-node` repo uses https://github.com/actions/publish-action which looks like it makes it pretty simple to set this up: https://github.com/actions/setup-node/blob/26961cf329f22f6837d5f54c3efd76b480300ace/.github/workflows/release-new-action-version.yml
Thanks for the PR!
I agree with @alexaryn in that responsibility of closing a stream should rest purely on the caller of `PdfWriter`, and not `PdfWriter` itself. Calling `pdf_writer.close()` or using the context manager...