ATProtoKit icon indicating copy to clipboard operation
ATProtoKit copied to clipboard

[Bug Fix] Fix Threading Errors By Passing Session to URI Resolution

Open aaronvegh opened this issue 1 year ago • 0 comments

Description

My spelunking of the code revealed that the fetchRecordForURI() method expects to have a working UserSession instance in order to get a pdsURL value. But because the method belongs to a bare utility class, it has no such association. Therefore, all attempts to resolve URIs used to resolve posts for threading will always fail. My solution is pretty naive, and I'm 95% sure y'all will shoot it down. I'm happy to play ball to help you get all the right parts talking to each other.

Linked Issues

#32

Type of Change

  • [x] Bug Fix
  • [ ] New Feature
  • [ ] Documentation

Checklist:

  • [ ] My code follows the ATProtoKit API Design Guidelines as well as the Swift API Design Guidelines.
  • [ ] I have performed a self-review of my own code and commented it, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings or errors in the compiler or runtime.
  • [ ] My code is able to build and run on my machine.

Screenshots (if applicable)

Attach any screenshots or GIFs showcasing the changes effect.

Additional Notes

Add any other notes about the Pull Request here.

Credits

If you want to be credited in the CONTRIBUTORS file, you can fill out the form below. Please don't remove the square brackets.

  • Name: [Aaron Vegh]
  • GitHub: [aaronvegh]
  • Bluesky: [aaronvegh.bsky.social]

aaronvegh avatar Sep 09 '24 00:09 aaronvegh