Black icon indicating copy to clipboard operation
Black copied to clipboard

AnimationController.remove doesn't remove animations

Open Dunnings opened this issue 2 years ago • 1 comments

The remove function in the AnimationController class doesn't actually remove the animation from this.mAnimations unless it is currently playing.

https://github.com/MassiveHeights/Black/blob/3b31e2a4568abefae7e8cb2e36b9dcf65b195491/src/animation/AnimationController.js#L51

How to fix:

Swap line 59 https://github.com/MassiveHeights/Black/blob/3b31e2a4568abefae7e8cb2e36b9dcf65b195491/src/animation/AnimationController.js#L59 and line 62 https://github.com/MassiveHeights/Black/blob/3b31e2a4568abefae7e8cb2e36b9dcf65b195491/src/animation/AnimationController.js#L62

Dunnings avatar Apr 05 '22 06:04 Dunnings