Naming convention in Release version 2025.05.1
Hi @meier-rene,
Thank you for all your work and the new release! While looking at it, it seems that the files previously named MassBank_NIST.msp and MassBank_RIKEN.mso were renamed to MassBank.msp_NIST and MassBank.msp_RIKEN. Is this intentional and will stay so for the future relases?
Best,
Hi Adriano, thanks for your interesst, well spotted. This change is intented and we will continue with this naming scheme in the future. Its a decission made by the developer team. We hope that it could clarify a bit more that these are both msp files of the whole MassBank, just different flavors of msp. Sorry for the inconvinience. Best, René
I don't quite understand what the developmental advantage is of changing the file ending instead of the name of the file? Surely this will potentially create more problems than it solves (and will disturb pipelines already set up on the previous naming conventions, as Adriano pointed out)?
Hi, possibly the confusion goes back to me, and indeed I didn't realise this resulted in a changed file extension.
We had people confused, importing both files, or thinking it'd be the subset of RIKEN and NIST spectra (the latter doesn't even exist in MassBank).
Bottom line, after a chat here we propose MassBank_NISTformat.msp and MassBank_RIKENformat.msp
to clarify they are different formats (dialects/flavours ...) and keep the *.msp extension.
Any vetos ? Yours, Steffen
Sounds better to me - no veto from my side.
No veto, also for the previous unusual version! Thanks a lot for clarifying 👍🏼