MassBank-data icon indicating copy to clipboard operation
MassBank-data copied to clipboard

Naming convention in Release version 2025.05.1

Open Adafede opened this issue 7 months ago • 5 comments

Hi @meier-rene,

Thank you for all your work and the new release! While looking at it, it seems that the files previously named MassBank_NIST.msp and MassBank_RIKEN.mso were renamed to MassBank.msp_NIST and MassBank.msp_RIKEN. Is this intentional and will stay so for the future relases?

Best,

Adafede avatar May 14 '25 21:05 Adafede

Hi Adriano, thanks for your interesst, well spotted. This change is intented and we will continue with this naming scheme in the future. Its a decission made by the developer team. We hope that it could clarify a bit more that these are both msp files of the whole MassBank, just different flavors of msp. Sorry for the inconvinience. Best, René

meier-rene avatar May 15 '25 06:05 meier-rene

I don't quite understand what the developmental advantage is of changing the file ending instead of the name of the file? Surely this will potentially create more problems than it solves (and will disturb pipelines already set up on the previous naming conventions, as Adriano pointed out)?

schymane avatar May 15 '25 06:05 schymane

Hi, possibly the confusion goes back to me, and indeed I didn't realise this resulted in a changed file extension. We had people confused, importing both files, or thinking it'd be the subset of RIKEN and NIST spectra (the latter doesn't even exist in MassBank). Bottom line, after a chat here we propose MassBank_NISTformat.msp and MassBank_RIKENformat.msp to clarify they are different formats (dialects/flavours ...) and keep the *.msp extension. Any vetos ? Yours, Steffen

sneumann avatar May 16 '25 09:05 sneumann

Sounds better to me - no veto from my side.

schymane avatar May 16 '25 10:05 schymane

No veto, also for the previous unusual version! Thanks a lot for clarifying 👍🏼

Adafede avatar May 16 '25 11:05 Adafede