core icon indicating copy to clipboard operation
core copied to clipboard

feature-913. Added new request.query() method for getting query params

Open garyburgmann opened this issue 5 years ago • 3 comments

feature-913. Added new request.query() method for getting query params specifically. If no key specified, return all. Also updated requeest.input to return all input if no key specified (simply calls the .all() method)

garyburgmann avatar Oct 05 '19 23:10 garyburgmann

This is not ready yet, need to write tests. Created the pull req for visibility/feedback on proposed changes :)

garyburgmann avatar Oct 05 '19 23:10 garyburgmann

Sounds good. Looks like this broke another test though so just take a look at that

josephmancuso avatar Oct 06 '19 22:10 josephmancuso

Yep for sure, just wanted to get some feedback on the input() changes before bothering to modify the tests

On Mon, 7 Oct 2019 at 8:34 am, Joseph Mancuso [email protected] wrote:

Assigned #914 https://github.com/MasoniteFramework/core/pull/914 to @garyburgmann https://github.com/garyburgmann.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/MasoniteFramework/core/pull/914?email_source=notifications&email_token=AGIRYIV5NHJTLVVCIAN4HVTQNJRYXA5CNFSM4I5ZYSVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUBMRV2A#event-2690194152, or mute the thread https://github.com/notifications/unsubscribe-auth/AGIRYIS5IA35ZFG4S7IDWCDQNJRYXANCNFSM4I5ZYSVA .

-- Gary Burgmann 0413 722 446

garyburgmann avatar Oct 06 '19 23:10 garyburgmann