Free-Games
Free-Games copied to clipboard
MasonStooksbury
ERROR though everything setup
Basically the order confirmation takes more time to load causing this to pop up. Please fix, thank you!
EDIT: I forgot to mention that it always tries to claim cookies though I NEVER got a cookie banner. Please tune it
EDIT2: sent a pull request fixing it
@xAffan, Thank you so much for reporting this error as well as submitting a fix for it. I'm currently out of town until Monday, but I will definitely take a look at it then. I really appreciate your effort and thanks for using this!
@lemasato and @Spifffff, is there any way I can bother you all to also take a look at this pull request to make sure it's good? I always like a fresh set of eyes. If not, that's totally cool, just figured I'd ask.
Yeah, I just looked and agree that nesting is a little odd if there is a 2nd argument available. I haven't used that particular event before so I didn't know about that lol Glad I got your input.
As for this case, mine loaded up pretty quick when I got the games yesterday, so this could be connection-related. I appreciate you taking a look, @lemasato, thank you.
I don't think it is silly. I could have duplicated the function with delay 30 but that would affect people for whom it loads faster. I think it's better to repeat the function if it fails because if it loads at 10 delay for someone then he would not have to wait 30 delay. And for those who it loads at 20, wouldn't have to wait till 30 delay. I think this is a better solution. If you have better ideas, feel free to close my pull request and add a better solution.
The bug happens for those with slow connection.
I added the delay 30 though you may close my pull request and better fix the code.
I'm no longer going to update this repository. Please use this new and improved one that makes use of the Epic Games desktop app rather than logging in via the browser:
https://github.com/MasonStooksbury/Free-Games-V2